Skip to content

Conversation

@mickenordin
Copy link

@mickenordin mickenordin commented Jan 18, 2026

This is an implementation of Conditional Logic. It is not well tested, and I would appreciate review and testing by others to see if it works as intended. I have created a few forms and clicked around to the best of my abilities, but I have implemented the fix for the benefit of others that need it and have no real use case myself to test with.

Fixes: #358

@mickenordin mickenordin force-pushed the kano-conditional branch 2 times, most recently from c7ff7a9 to 7887848 Compare January 18, 2026 18:57
@codecov
Copy link

codecov bot commented Jan 18, 2026

Codecov Report

❌ Patch coverage is 56.88073% with 141 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
lib/Service/SubmissionService.php 48.87% 68 Missing ⚠️
lib/Db/QuestionMapper.php 0.00% 39 Missing ⚠️
lib/Migration/Version050300Date20260118000000.php 0.00% 19 Missing ⚠️
lib/Controller/ApiController.php 86.04% 12 Missing ⚠️
lib/Service/FormsService.php 93.47% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

@mickenordin mickenordin force-pushed the kano-conditional branch 7 times, most recently from 2d5f073 to 50a1acd Compare January 18, 2026 20:17
@mickenordin
Copy link
Author

Codecov Report

❌ Patch coverage is 56.88073% with 141 lines in your changes missing coverage. Please review.
Files with missing lines Patch % Lines
lib/Service/SubmissionService.php 48.87% 68 Missing ⚠️
lib/Db/QuestionMapper.php 0.00% 39 Missing ⚠️
lib/Migration/Version050300Date20260118000000.php 0.00% 19 Missing ⚠️
lib/Controller/ApiController.php 86.04% 12 Missing ⚠️
lib/Service/FormsService.php 93.47% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

Updated with more tests so threshold is well exceeded

This is a WIP implementation of Conditional Logic. It is not well
tested, and I would appreciate review and testing by others to see if
it works as intended. I have created a few forms and clicked around to
the best of my abilities, but I have implemented the fix for the benefit
of others that need it and have no real use case myself to test with.

Fixes: #358

Signed-off-by: Micke Nordin <[email protected]>
@mickenordin mickenordin changed the title WIP: Conditional Logic Conditional Logic Jan 19, 2026
@mickenordin mickenordin marked this pull request as ready for review January 19, 2026 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support conditional logic

2 participants